-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Coupled Model and Delete adf_quick_run.ipynb now that link_to_ADF.ipynb exists #198
base: main
Are you sure you want to change the base?
Conversation
atm:
adf_quick_run:
parameter_groups:
none:
adf_path: ../../../externals/ADF
config_path: .
config_fil_str: "config_f.cam6_3_119.FLTHIST_ne30.r328_gamma0.33_soae.001.yaml" We've talked about encouraging folks to use Another concern is that maybe @justin-richling, @brianpm, or @nusbaume want to provide an example of invoking ADF from a notebook instead of the command line. If that's not the case, maybe we could remove the quick run notebook but run a different atmosphere notebook in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should've marked "request changes" with #198 (comment)
Hi @mnlevy1981 @TeaganKing, after discussing it in an ADF meeting we decided that there isn't really a need to have an example of the ADF being called from a notebook (calling it directly in python or from the command line is fine with us), so feel free to move ahead with this particular PR. Thanks for checking! |
Thanks @nusbaume for this feedback. @mnlevy1981 I removed this from the coupled model config file, too. That said, I'm not in any rush to get this in, and it could certainly be done as a larger removal (or updating) of the coupled model example. |
The past few commits address these changes:
Remaining issues:
|
Is this a case that was run on the CAM-SE grid instead of the FV grid? I bet something like if "lndgrid" in ds[var].dims:
# find index of lndgrid close to 300 E, 10 S
ds[var].isel(lndgrid=lndgrid_ind).plot(hue="case", y="levsoi")
else:
ds[var].sel(lon=300, lat=-10, method="nearest").plot(hue="case", y="levsoi") would work (where the tricky part is finding the |
I found the closest land indices by finding a minimum non-NaN distance between the landgrid and the lat/lon values. |
This PR removes the old
adf_quick_run
notebook since we now prefer supportinglink_to_ADF.ipynb
and the helper scripts that create the ADF configuration filesAll PRs Checklist:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?