Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUPID_RUN_SERIAL to env_postprocessing.xml #208

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnlevy1981
Copy link
Collaborator

@mnlevy1981 mnlevy1981 commented Mar 18, 2025

If CUPID_RUN_SERIAL is TRUE, add --serial flag when running diagnostics

Description of changes:

  • Please add an explanation of what your changes do and why you'd like us to include them.

All PRs Checklist:

If CUPID_RUN_SERIAL is TRUE, add --serial flag when running diagnostics
@mnlevy1981
Copy link
Collaborator Author

It looks like cupid-timeseries accepts the --serial flag, and uses it to determine whether or not to distribute calls of call_ncrcat():

        if serial:
            for cmd in list_of_commands:
                call_ncrcat(cmd)
        else:  # if not serial
            # Now run the "ncrcat" subprocesses in parallel:
            with mp.Pool(processes=num_procs) as mpool:
                _ = mpool.map(call_ncrcat, list_of_commands)
            # End with

however, the click description is copied from run_diagnostics:

$ git grep click.*serial cupid/
cupid/run_diagnostics.py:@click.option("--serial", "-s", is_flag=True, help="Do not use LocalCluster objects")
cupid/run_timeseries.py:@click.option("--serial", "-s", is_flag=True, help="Do not use LocalCluster objects")

So I want to clean that up in this PR as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant