Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for THM USE_THETA_M attribute #838

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Check for THM USE_THETA_M attribute #838

merged 3 commits into from
Mar 14, 2025

Conversation

braczka
Copy link
Contributor

@braczka braczka commented Mar 12, 2025

Description:

Mandate in WRF-DART that if THM variable is present in &model_nml it must be ' perturbed dry adiabatic potential temperature'. This is set through USE_THETA_M option in WRF &dynamics namelist.

Fixes issue

Fixes #837

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

None required.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@braczka braczka added the wrf Weather Research & Forecasting Model label Mar 12, 2025
@braczka
Copy link
Contributor Author

braczka commented Mar 13, 2025

Tested this code using USE_THETA_M = 0 and USE_THETA_M = 1 and gives the expected behavior. /glade/work/bmraczka/DART/models/wrf/MattW_bug/perfect_model_obs

Current WRF 4 and older WRF 3 wrfinput_d01 versions all contain USE_THETA_M as a global attribute, thus no need to set default value behavior in this DART issue. @hkershaw-brown please give this a check, but I think it is ready to go. Please include in the next release, as this problem is not really detectable in practice, and not documented well within WRF unless we mandate exact configuration of THM here within DART.

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Mar 14, 2025
@hkershaw-brown hkershaw-brown merged commit 33c310b into main Mar 14, 2025
5 checks passed
@hkershaw-brown hkershaw-brown deleted the WRF_THM branch March 14, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release wrf Weather Research & Forecasting Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for WRF THM variable USE_THETA_M setting
2 participants