Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set cfields_to_perturb in cam-common-code from model_mod namelist #846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hkershaw-brown
Copy link
Member

Description:

The fields to perturb from model_nml for cam-fv and cam-se was not getting communicated to cam-common-code, so pert_model_copies exits without perturbing and fields since cfields_to_perturb=""

if (cfields_to_perturb(i) == '') exit

Fixes issue

fixes #845

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Ran cam-fv filter case perturbing from a single instance, no inflation, not assimilating obs, checked output was perturbed.
Before fix output == input with perturb.
Not run cam-se yet.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • models/cam-fv/model_mod.f90: Language not supported
  • models/cam-se/model_mod.f90: Language not supported

Copy link
Contributor

@kdraeder kdraeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I didn't notice that you requested my review.
This fix looks straightforward.

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cam fv & cam-se not perturbiing when custom_routine_to_generate_ensemble is set
2 participants