Skip to content

Add aerosol and cloud specific configurations - #279

Merged
boulderdaze merged 5 commits into
mainfrom
271-add-miam-config
Jun 24, 2026
Merged

Add aerosol and cloud specific configurations#279
boulderdaze merged 5 commits into
mainfrom
271-add-miam-config

Conversation

@boulderdaze

@boulderdaze boulderdaze commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR:

// Current
"rate constants": {
        "CLOUD": { "A": 1.333e8, "C": 4430.0 }

// This PR
"rate constants": {
        "CLOUD": { "type": "ARRHENIUS", "A": 1.333e8, "C": 4430.0}
      }
  • The configuration defines equilibrium constants using Arrhenius-style parameters but, the implementation is in the form of a van't Hoff formulation to compute the temperature-dependent equilibrium constant.
    The updated configuration now reflect this behavior explicitly.
// Current
"equilibrium constant": {
        "A": 1.08e-9,
        "C": 1120.0 }

// This PR
"equilibrium constant": {
        "type": "ARRHENIUS_REFERENCE_TEMPERATURE", "A": 1.08e-9, "C [K]": 1120.0, "T0 [K]": 298.15 }

@boulderdaze boulderdaze self-assigned this Jun 24, 2026
@boulderdaze boulderdaze added this to the Cloud Chemistry milestone Jun 24, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.57%. Comparing base (f3203c4) to head (5bee7cb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #279       +/-   ##
===========================================
- Coverage   70.00%   31.57%   -38.43%     
===========================================
  Files           5        4        -1     
  Lines          10       19        +9     
===========================================
- Hits            7        6        -1     
- Misses          3       13       +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boulderdaze
boulderdaze marked this pull request as ready for review June 24, 2026 02:06
@boulderdaze
boulderdaze requested a review from K20shores June 24, 2026 02:06

@K20shores K20shores left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume a follow-on PR will add the parsing/validation of this?

Please also add another example to the examples folder for v1.2. Consider making it explicit which configuration has which version

Comment thread test/integration/integration_configs/cam_clound_chemistry.json Outdated
Co-authored-by: Kyle Shores <kyle.shores44@gmail.com>
@boulderdaze
boulderdaze requested a review from K20shores June 24, 2026 15:14
@boulderdaze
boulderdaze merged commit a375b97 into main Jun 24, 2026
27 of 29 checks passed
@boulderdaze
boulderdaze deleted the 271-add-miam-config branch June 24, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants