Add aerosol and cloud specific configurations - #279
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
===========================================
- Coverage 70.00% 31.57% -38.43%
===========================================
Files 5 4 -1
Lines 10 19 +9
===========================================
- Hits 7 6 -1
- Misses 3 13 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
boulderdaze
marked this pull request as ready for review
June 24, 2026 02:06
K20shores
requested changes
Jun 24, 2026
K20shores
left a comment
Collaborator
There was a problem hiding this comment.
I assume a follow-on PR will add the parsing/validation of this?
Please also add another example to the examples folder for v1.2. Consider making it explicit which configuration has which version
Co-authored-by: Kyle Shores <kyle.shores44@gmail.com>
K20shores
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Part of Add MIAM types to canonical
Mechanism#271Related PR: Update dissolved reaction and dissolved reversible reaction structs based on CAM cloud chemistry configuration miam#65
Cleans up the CAM cloud chemistry configuration. This includes:
rate constantis ambiguous. Based on the implementation, the type is specified as below:The updated configuration now reflect this behavior explicitly.