Rename Arrhenius reference temperature to Equilibrium - #299
Merged
Conversation
boulderdaze
marked this pull request as ready for review
July 15, 2026 20:21
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 88.03% 88.08% +0.04%
==========================================
Files 44 44
Lines 2474 2442 -32
==========================================
- Hits 2178 2151 -27
+ Misses 296 291 -5
🚀 New features to boost your workflow:
|
K20shores
requested changes
Jul 15, 2026
| }, | ||
| "equilibrium constant": { | ||
| "type": "ARRHENIUS_REFERENCE_TEMPERATURE", "A": 1725.0, "C [K]": 0.0, "T0 [K]": 298.15 | ||
| "type": "EQUILIBRIUM", "A": 1725.0, "C [K]": 0.0, "T0 [K]": 298.15 |
Collaborator
There was a problem hiding this comment.
Are there docs for this in mechanism configuration? If so we should update them
Contributor
Author
There was a problem hiding this comment.
Created an issue:
K20shores
approved these changes
Jul 16, 2026
boulderdaze
marked this pull request as draft
July 16, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: