Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify filter_variance_skimage_napari.py #673

Merged
merged 1 commit into from
May 6, 2024

Conversation

tischi
Copy link
Collaborator

@tischi tischi commented May 6, 2024

I was trying to reproduce our code in filter_variance_skimage_napari.py but failed.

Something was wrong with the computation of the variance image, it looked always very noisy and thus I could not threshold it successfully.

I changed this now.

Even though it introduces the concept of a function I find it much more readable, robust and useful than the previous approach, where a lot of code and mental load went into how to compute a variance; and, in fact, it did not work, for me.

I would have no worries that the students would understand this, because the function is super simple; and it actually very nicely fits the concept map of that you do some local math in a region of the image.

@tischi
Copy link
Collaborator Author

tischi commented May 6, 2024

I need to teach this tomorrow, thus please comment today; sorry for the rush.

Copy link
Collaborator

@manerotoni manerotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is very simple and the explanation is clear. I wonder if one should just plainly run it once on a chunk of image unit16_image[0:10,0:10].
This will help understanding the new concept of generic_filter

@tischi tischi merged commit bac3fb9 into master May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants