Add previous_status in metadata of telemetry event (#11)

NFIBrokerage · Jul 21, 2023 · 46f58d1 · 46f58d1
1 parent 19df512
commit 46f58d1
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,12 @@ Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to
 
 -->
 
+## 1.1.3 - 2023-07-21
+
+### Added
+
+- Added `previous_status` to metadata of telemetry event.
+
 ## 1.1.2 - 2023-07-14
 
 ### Changed

diff --git a/lib/beeline/health_checker.ex b/lib/beeline/health_checker.ex
@@ -52,7 +52,7 @@ defmodule Beeline.HealthChecker do
     :get_stream_position,
     :get_head_position,
     :hostname,
-    :status,
+    status: :up_to_date,
     interval: 0,
     drift: 0,
     acceptable_behind_by: 5,

diff --git a/lib/beeline/health_checker/impl.ex b/lib/beeline/health_checker/impl.ex
@@ -25,7 +25,8 @@ defmodule Beeline.HealthChecker.Impl do
             current_position: situation.current_listener_position,
             head_position: situation.current_stream_position,
             alive?: _alive?(state.producer),
-            status: situation.status
+            status: situation.status,
+            previous_status: state.status
           })
 
         state = %HealthChecker{

diff --git a/test/beeline/health_checker/impl_test.exs b/test/beeline/health_checker/impl_test.exs
@@ -62,6 +62,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :up_to_date,
+                         previous_status: _,
                          prior_position: _,
                          current_position: 2,
                          head_position: 5
@@ -81,6 +82,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :stuck,
+                         previous_status: :up_to_date,
                          prior_position: _,
                          current_position: 2,
                          head_position: 5
@@ -113,6 +115,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :up_to_date,
+                         previous_status: _,
                          prior_position: _,
                          current_position: 2,
                          head_position: 5
@@ -138,6 +141,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :up_to_date,
+                         previous_status: :up_to_date,
                          prior_position: 2,
                          current_position: 3,
                          head_position: 7
@@ -170,6 +174,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :caught_up,
+                         previous_status: _,
                          prior_position: _,
                          current_position: 2,
                          head_position: 3
@@ -203,6 +208,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :stuck,
+                         previous_status: _,
                          prior_position: 2,
                          current_position: 2,
                          head_position: 12
@@ -236,6 +242,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :stuck,
+                         previous_status: _,
                          prior_position: 2,
                          current_position: 2,
                          head_position: 12
@@ -269,6 +276,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :falling_behind,
+                         previous_status: _,
                          prior_position: 2,
                          current_position: 5,
                          head_position: 15
@@ -302,6 +310,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :falling_behind_more,
+                         previous_status: _,
                          prior_position: 2,
                          current_position: 3,
                          head_position: 16
@@ -335,6 +344,7 @@ defmodule Beeline.HealthChecker.ImplTest do
                       {:telemetry_event,
                        %{
                          status: :catching_up,
+                         previous_status: _,
                          prior_position: 2,
                          current_position: 5,
                          head_position: 12