Merged
Conversation
dzalkind
approved these changes
Feb 4, 2026
Collaborator
dzalkind
left a comment
There was a problem hiding this comment.
For my own understanding, when should the units of FatigueParams be in stress vs. force?
Member
Author
It works for both. Depending on the input to pCrunch FatigueParams, the units may be force if interested in DELs or Stress if using more classic S-N curve models. The important piece is the units prefix (none or 'k' or 'M' etc). You can see the logic in the code at: |
Pull Request Test Coverage Report for Build 21691761195Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The different units of OpenFAST load outputs must be taken into account better in some of the fatigue calculations, especially when using an S-N curve from the library of DNV curves available in pCrunch/fatpack.
Type of change
Testing