Support async storage #1152
Open
Support async storage #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 15, 2023 20:24
* Move KV into krill * Move Storable to storage::types * Embed used functions from kvx and convert from trait to enum.
timbru
changed the title
added 6 commits
November 20, 2023 10:40
This was referenced Dec 7, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
KeyValueStoreenum async, which, of course, has a rather big impact on the code base.The enum delegates to
KeyValueStoreImplwhich is still sync. The actualDiskandMemoryimplementations are also sync. We can make this implementation async in a future a PR. We may be able to remove the indirection to theKeyValueStoreImplenum then as well. We will see. When this is done, we can also port thekvximplementation for postgresql - albeit, using async.Just mentioning this here now so that it is clear that there is more work, but I intentionally wanted to keep this PR a bit smaller so that it can be reviewed better.