Enable exchange of runoff DOC from Land to Ice used in CMIP7 ESM4.5#1034
Open
nikizadehgfdl wants to merge 5 commits intoNOAA-GFDL:dev/gfdlfrom
Open
Enable exchange of runoff DOC from Land to Ice used in CMIP7 ESM4.5#1034nikizadehgfdl wants to merge 5 commits intoNOAA-GFDL:dev/gfdlfrom
nikizadehgfdl wants to merge 5 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
nikizadehgfdl
commented
Feb 18, 2026
nikizadehgfdl
commented
- Address coupler issue 163
- Land component calcutes the DOC (Dissolved Organic Carbon) content flux in runoff (KgC/m2/s)
- COBALT needs access to that runoff flux (currently done via data_override from file)
- Ocean component needs to make the flux available to COBALT
- Ice component needs to make the flux available to ICE
- land_ice_flux_exchange needs to exchange the flux from Land to Ice
- Land component calcutes the DOC (Dissolved Organic Carbon) content flux in runoff (KgC/m2/s) - COBALT needs access to that runoff flux (currently done via data_override from file) - Ocean component needs to make the flux available to COBALT - Ice component needs to make the flux available to ICE - land_ice_flux_exchange needs to exchange the flux from Land to Ice
Hallberg-NOAA
requested changes
Feb 20, 2026
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Please correct the units and unit conversion factors as noted in the comments attached to specific lines, and also please add the logical test (and optional argument to allocate_forcing_by_group()) so that the array that is being added here is only being allocated if it would actually be used.
| if (fluxes%dt_buoy_accum < 0) then | ||
| call allocate_forcing_type(G, fluxes, water=.true., heat=.true., ustar=.not.CS%nonBous, press=.true., & | ||
| fix_accum_bug=.not.CS%ustar_gustless_bug, tau_mag=CS%nonBous) | ||
| fix_accum_bug=.not.CS%ustar_gustless_bug, tau_mag=CS%nonBous, carbon=.true.) |
Member
There was a problem hiding this comment.
I think that the value of carbon here should not be hard-coded, but rather it should be run-time configurable or configurable based in information passed in from the coupler, depending on whether this is a physical coupled model or a full ESM that is being used. Assuming that MOM6 is always run as a full ESM does not seem wise to me.
- Nothing will be allocated/avaliable unless a parameter is set in overrides # Allow Carbon Runoff diagnostics #override ALLOW_CARBON_FLUX_EXCHANGE = True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.