Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New subtool: Fre pp histval #377

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

New subtool: Fre pp histval #377

wants to merge 12 commits into from

Conversation

Ciheim
Copy link
Collaborator

@Ciheim Ciheim commented Mar 4, 2025

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@Ciheim Ciheim self-assigned this Mar 4, 2025
@Ciheim Ciheim changed the title New subtool: Fre pp ncvalidate New subtool: Fre pp histval Mar 11, 2025
@Ciheim Ciheim marked this pull request as ready for review March 11, 2025 19:12
Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some kind of test needed. Minimal test, with tiny cdf Netcdf example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants