Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require python 3.10 and remove cylc-uiserver as a dependency #384

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

ceblanton
Copy link
Collaborator

Describe your changes

Python 3.9 is too old (not receiving security updates) and probably causes fre analysis install issues.

Hand testing showed cylc-uiserver was causing the solver to always use 3.9.

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@ceblanton ceblanton requested a review from ilaflott March 20, 2025 16:43
@ceblanton ceblanton changed the title Require python 3.10 or later, and remove cylc-uiserver as a dependency Require python 3.10 and remove cylc-uiserver as a dependency Mar 20, 2025
@ceblanton
Copy link
Collaborator Author

Woohoo! Ian I can't believe you practically eyeballed both problems successfully here. Pinning python to 3.10 fixed the sql build problem, and pip installing defusedxml resolved the genbadge problem.

Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy we just needed defusedxml in addition to genbadge, thanks for giving that approach a shot.

Also, thrilled to be moving beyond 3.9. Cheers!

@ilaflott ilaflott merged commit def712a into main Mar 21, 2025
2 checks passed
@ilaflott ilaflott deleted the bump-python-version branch March 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants