Conversation
Newmodels
New models and methods
New methods required for the UI
New methods added
Merge of last changes
Two methods migrated from raw cql queries
New methods for roles, organizations and contacts
Method to get all the persons with a determined rolename
Just a simple name change
Expansion of the role model
Member
|
Seemes fine. Not sure about the six inclusion, since I dont really see a point in keeping py2 alive giving 2020 is so close, and all our installations are py3, but I guess it doesn't hurt. |
mkrogh
reviewed
Aug 26, 2019
| MATCH (n:Node {{handle_id: {{handle_id}}}}) | ||
| SET n.{property} = {value} | ||
| RETURN n | ||
| """.format(property=property, value=value) |
Member
There was a problem hiding this comment.
Not that it matters a lot (and our code is probably full of these things all over the place), but this is not injection safe.
Collaborator
Author
There was a problem hiding this comment.
I don't think setting properties ever was injection safe (and I think you are correct that the problem can be found elsewhere to).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds models for Organizations, Contacts and Roles.