Feature add: Download wind resource for Alaska #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for other resource heights
elenya-grant
added
documentation
genevievestarke
approved these changes
Apr 8, 2025
johnjasa
requested changes
Apr 8, 2025
Comment on lines
157
to
177
| def combine_and_write_srw_files(file_resource_heights, output_filepath): | ||
|
|
||
| data = [None] * 2 | ||
| for height, f in file_resource_heights.items(): | ||
| if os.path.isfile(f): | ||
| with open(f) as file_in: | ||
| csv_reader = csv.reader(file_in, delimiter=',') | ||
| line = 0 | ||
| for row in csv_reader: | ||
| if line < 2: | ||
| data[line] = row | ||
| else: | ||
| if line >= len(data): | ||
| data.append(row) | ||
| else: | ||
| data[line] += row | ||
| line += 1 | ||
|
|
||
| with open(output_filepath, 'w', newline='') as fo: | ||
| writer = csv.writer(fo) | ||
| writer.writerows(data) |
There was a problem hiding this comment.
Could you add a docstring please?
| } | ||
| return combined_resource_data | ||
|
|
||
| def combine_CSV_to_wind_data(file_resource_heights, fake_resource_year = '1900'): |
There was a problem hiding this comment.
What is this fake_resource_year used for? If it's just to pass in a year to other functions and has no real meaning, could we change it to None and then modify the functions that use it elsewhere? Or maybe even have None be the default for those functions and then only use the year if it's not None. Feel free to call me if this isn't making sense, I just want to avoid confusion about why there's a fake_resource_year
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: John Jasa <[email protected]>
| if isinstance(wind_resource_filepath,list): | ||
| if len(wind_resource_filepath) != len(resource_heights): | ||
| raise ValueError("wind resource filepath must be a list of filenames that same length as") | ||
| file_resource_heights = dict(zip(resource_heights,filepaths)) |
There was a problem hiding this comment.
Should the filepaths variable be defined here?
johnjasa
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Calls to WIND Toolkit Alaska
Added ability to make API calls to WIND Toolkit Alaska and download resource data for Alaska sites. This also required added tools to convert csv files to the proper wind resource data format that is expected by WindPlant.
PR Checklist
RELEASE.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
Impacted areas of the software
modified files:
hopp/simulation/technologies/resource/wind_resource.pycombine_files()function to callcombine_and_write_srw_files()function frompysam_wind_tools.pyhopp/tools/resource/wind_tools.pyhopp/simulation/technologies/sites/site_info.pywind_resource_regionis new attribute that can be used to specify the wind resource region as Alaska ("conus" is default for existing wind resource downloads, "ak" is used for Alaska)hopp/simulation/technologies/resource/resource.pycall_api()updated to replace possible weird characters in download data (mostly relevant for BC-HRRR dataset which is not yet included)tests added:
tests/hopp/test_site_info.pytest_alaska_wind_resource()new integration test of Alaska wind resource data with SiteInfotests/hopp/test_wind_resource_tools.py: test the new functioncombine_wind_files()inhopp/tools/resource/pysam_wind_tools.pyfor combining wind resource datatest_pysam_combine_wind_files_csvtest_pysam_combine_wind_files_srwtests/hopp/test_wind.pytest_alaska_wind_floris: tests that floris simulation is compatible with resource data format from Alaska wind datatest_alaska_wind_pysam: tests that pysam simulation is compatible with resource data format from Alaska wind datanew files:
hopp/tools/resource/pysam_wind_tools.py: functions to convert csv files into wind data format and combine wind resource files (either csv or srw)hopp/simulation/technologies/resource/alaska_wind.py: script similar to wind_resource.py that downloads wind resource data for Alaska.hopp/simulation/resource_files/wind/66.68_-162.5_WTK_Alaksa_2019_60min_80m_100m.csv: resource file for Alaska site that is used in new testschanges to docs/ files:
docs/_toc.yaml: updated to include Alaska winddocs/api/resource/index.md: updated to include Alaska winddocs/api/resource/wind_api.md: updated to specify that this is for continental U.S. sites and include the constraints for wind resource year.docs/api/resource/alaska_wind.md: new file with documentation for Alaska wind API callsAdditional supporting information
Test results, if applicable