Feature/ldes framework #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates to LDES initialization
* Update README.md to not specify `coin-or-cbc` version. --------- Co-authored-by: John Jasa <[email protected]>
|
I am a little surprised that the LDES system has a less-negative AEP than the battery. This leads to a lower overall LCOE and other differences. It could be an efficiency thing, but I thought I checked that in the LDES tests. The maximum and minimum SOC are the same between battery and LDES. I'm wondering if perhaps @genevievestarke or @bayc you have any ideas. |
genevievestarke
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add meaningful title here
PR Checklist
RELEASE.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
Impacted areas of the software
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Additional supporting information
Test results, if applicable