documentation updates #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first iteration of the updates before our discussion Jan 6th 2025.
updates to diffusion_functions_elec, input_data_functions, and financial_functions.
michaelavs
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Great start! The comments I added can be merged directly into your pull request without needing to change the code locally and re-pushing changes. After accepting [any of] the changes, make sure you re-sync your local branch with this branch from the main page of the PR and then doing a git pull on your local copy
| solar_agents : 'Class' | ||
| Instance of Agents class with either user pre-generated or new data | ||
| solar_agents : :class: `agents.Agents` | ||
| Instance of Agents class with either user pre-generated or user generated agent |
There was a problem hiding this comment.
This definition would also be updated to remove the "user generated" reference
| ValueError | ||
| Raised if region in the pickle file | ||
| "Region not present within pre-generated agent file - Edit Inputsheet" | ||
| ValueError |
There was a problem hiding this comment.
Could remove line 442 through 44 by removing the agent_file_statue var
| def process_load_growth(load_growth): | ||
| """ | ||
| Returns the trajectory of the load growth rates over time relative to a base year of 2014 | ||
| # def process_load_growth(load_growth): |
There was a problem hiding this comment.
As above, can remove this chunk if it is unused/outdated as the code will be tracked through GitHub
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Co-authored-by: Michaela Sizemore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first iteration of the updates before our discussion Jan 6th 2025.