Update to allow for toggling on/off logging each API request to stdout or to a log file

[Jakub Wlodek (jwlodek)]

No description provided.

[Copilot]

Copilot review overview

🟡 Changes recommended

The timestamp implementation uses localtime_r, which breaks the supported Windows build.

Review effort: Balanced
Findings: 1

Open (1)

• Use a Windows-compatible alternative to POSIX-only localtime_r · New

What changed in this PR

Adds configurable per-request HTTP logging to stdout or a selected file.

Changes:

• Adds thread-safe request logging to the XSPD API.
• Exposes logging controls through EPICS records and the operator interface.
• Adds unit tests for logging behavior and errors.

File	Description
xspdApp/​tests/​TestXSPDAPI.cpp	Tests request logging behavior.
xspdApp/​src/​XSPDAPI.h	Declares logging API and state.
xspdApp/​src/​XSPDAPI.cpp	Implements request logging.
xspdApp/​src/​ADXSPDParamDefs.h	Defines the logging parameter.
xspdApp/​src/​ADXSPDParamDefs.cpp	Creates the logging parameter.
xspdApp/​src/​ADXSPD.h	Declares driver logging handlers.
xspdApp/​src/​ADXSPD.cpp	Integrates logging with driver parameters.
xspdApp/​op/​bob/​ADXSPD.bob	Adds operator logging controls.
xspdApp/​Db/​ADXSPD.template	Adds logging and file records.
xspdApp/​Db/​ADXSPD_settings.req	Persists file settings.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Use a Windows-compatible alternative to POSIX-only localtime_r

[Copilot]

Copilot review overview

🟡 Changes recommended

Logging exposes an unsafe public method and can report an enabled state after file activation fails.

Review effort: Balanced
Findings: 1

Open (1)

• Public LogRequest permits unsynchronized access to request logging state · New

Previously missed (1)

In code that hasn't changed since last review

Enable failure leaves logging parameter enabled after logging is disabled

xspdApp/​src/​ADXSPD.cpp:834

If enabling fails while this parameter already reads 1 (for example, its directory was removed and the client writes 1 again), EnableRequestLogging has already disabled logging, but the exception returns before the parameter is updated. The readback then remains Enabled even though no requests are logged. Reset the parameter to 0 and publish callbacks before propagating the failure, as the writeOctet failure path does.