Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new device types: Wiener Crate power supplies and Keithley 428 current amplifiers. The changes introduce complete role definitions with templates, schemas, examples, and supporting files for EPICS IOC deployment.
- Addition of SNMP-based Wiener Crate monitoring and control infrastructure with MIB files and database definitions
- Addition of Keithley 428 current amplifier support with basic IOC configuration
- Module definitions for both snmp_nscl (for Wiener) and keithley428 with their respective dependencies and configuration
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
roles/install_module/vars/snmp_nscl_3cd2804.yml |
Defines SNMP-NSCL module for Wiener Crate with net-snmp dependencies |
roles/install_module/vars/keithley428_0000000.yml |
Defines Keithley428 module with placeholder version |
roles/device_roles/wienercrate/templates/postInit.cmd.j2 |
Autosave configuration template for Wiener Crate |
roles/device_roles/wienercrate/templates/base.cmd.j2 |
Base IOC startup script for Wiener Crate with SNMP configuration |
roles/device_roles/wienercrate/tasks/main.yml |
Ansible tasks to deploy Wiener Crate IOC files and templates |
roles/device_roles/wienercrate/schema.yml |
Schema defining required environment variables for Wiener Crate |
roles/device_roles/wienercrate/files/wienerCrate.db |
EPICS database for Wiener Crate basic monitoring PVs |
roles/device_roles/wienercrate/files/supplies.db |
EPICS database for individual power supply channel control |
roles/device_roles/wienercrate/files/WIENER-CRATE-MIB.txt |
Standard WIENER-CRATE MIB definition file |
roles/device_roles/wienercrate/example.yml |
Example configuration for deploying a Wiener Crate IOC |
roles/device_roles/wienercrate/README.md |
Documentation for Wiener Crate role |
roles/device_roles/keithley428/templates/base.cmd.j2 |
Base IOC startup script for Keithley 428 |
roles/device_roles/keithley428/tasks/main.yml |
Ansible tasks to deploy Keithley 428 IOC template |
roles/device_roles/keithley428/schema.yml |
Schema defining required environment variables for Keithley 428 |
roles/device_roles/keithley428/example.yml |
Example configuration for deploying a Keithley 428 IOC |
roles/device_roles/keithley428/README.md |
Documentation for Keithley 428 role |
roles/deploy_ioc/vars/wienercrate.yml |
IOC deployment variables for Wiener Crate with autosave configuration |
roles/deploy_ioc/vars/keithley428.yml |
IOC deployment variables for Keithley 428 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a1d4a8e to
3c897de
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Apparently this never existed, not sure why a role was made or how it was used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Keithley428 role from ioc-deploy-roles.
This role needs a repo called https://github.com/NSLS-II/Keithley428, but it doesn't exist yet.
Im not sure what to do next to resolve this.