Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive support for the ADXSPD (X-SPRESS Detector) driver to the Ansible collection, enabling automated deployment and configuration of ADXSPD IOC instances.
Key Changes:
- Added complete device role for ADXSPD including templates, schema, example configuration, and deployment tasks
- Defined module dependency configuration for ADXSPD with version set to "latest"
- Updated build tooling in Makefile and pixi.toml to use
pixi runcommands instead of direct script invocation
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/install_module/vars/adxspd_latest.yml | Defines ADXSPD module configuration with dependencies on adcompvision, adcore, and ffmpeg_server |
| roles/device_roles/adxspd/templates/base.cmd.j2 | IOC startup command template with ADXSPDConfig setup and database loading for main detector and modules |
| roles/device_roles/adxspd/templates/auto_settings.req.j2 | Auto-save request file template for ADXSPD settings and optional plugins |
| roles/device_roles/adxspd/tasks/main.yml | Ansible tasks to install base.cmd and auto_settings.req templates with proper permissions |
| roles/device_roles/adxspd/schema.yml | Schema definition for ADXSPD device type with required and optional environment variables |
| roles/device_roles/adxspd/example.yml | Example configuration for ADXSPD device instance deployment |
| roles/device_roles/adxspd/README.md | Basic documentation for the ADXSPD Ansible role |
| roles/deploy_ioc/vars/adxspd.yml | IOC deployment variables including template paths, request files, and device-specific environment settings |
| pixi.toml | Updated task definitions to use direct Python script invocation instead of Makefile targets |
| Makefile | Modified to use pixi run commands for all tasks, delegating execution to pixi.toml definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… add-adxspd-role
…c_deploy into add-adxspd-role
… add-adxspd-role
… add-adxspd-role
Collaborator
Author
|
Deployment on RHEL8 failure is expected, since the driver requires C++17 or newer (which is not supported with the default gcc version on RH8), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.