You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this looks good! Do we still need this with the image plotter?
If we use it, I might suggest using a tool to choose min max according to a histogram. I usually use something like this here.
I think in general it would be nice to have a histogram widget that plots a histogram of an image that would allow a user to select limits themselves, like pyqtgraph. I wonder if it's worth adding in matplotlib, or do some searching
I think my implementation is too simple 😃. We may need to use the CrossSection class from xray-vision, which would add a color bar, and cross-hair with corresponding interactive plots. vmin/vmax can be supplied either via the kwargs, or via a menu in the MPL window. Your option may be a useful addition! But it's probably worth to add it to xray-vision rather than to this beamline-specific profile.
CJ-Wright
pushed a commit
to CJ-Wright/profile_collection
that referenced
this pull request
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a simple plotting function for visualizing the images. Usage:
Attn @jrmlhermitte @milinda2014