Merged
Conversation
Contributor
|
It seems like the used version of stencil is not compatible with the used version of jest; running |
Collaborator
Author
|
Thank you, I have now downgraded the jest dependencies accordingly |
mbastian93
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to upgrade dependencies listed in #15
❗ untested, no local backend set up to test anymore. Build works and UI seems to work as expected. cc @mbastian93
Note: To upgrade @d4l/web-components-library to v3, package
@stencil/routerwould have to be replaced with https://github.com/ionic-team/stencil-router-v2. However, development on the v2 router was recently dropped for lack of maintainers. The v2 router itself works just fine, has a very small and clean code base and provides plenty of improvements over the v1 router (it will also remove a lot of warnings in the DevTools console currently coming from the v1 version), that's why D4L's web components library decided to upgrade to it despite it never having officially reached a final version.