Skip to content

Commit

Permalink
[Opt] Remove atomicExch for Eigen::half
Browse files Browse the repository at this point in the history
  • Loading branch information
rhdong committed Feb 1, 2023
1 parent 771a2de commit eb68bd0
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions include/merlin/utils.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,6 @@ __inline__ __device__ signed char atomicExch(signed char* address,
return old;
}

// TODO(jamesrong): this API will not confirm atomic, just for compiling
// successfully with framework in the TensorFlow ecosystem.
#ifdef GOOGLE_CUDA
__inline__ __device__ Eigen::half atomicExch(Eigen::half* address,
Eigen::half val) {
Eigen::half old = *address;
*address = val;
return old;
}
#endif

__inline__ __device__ int64_t atomicAdd(int64_t* address, const int64_t val) {
return (int64_t)atomicAdd((unsigned long long*)address, val);
}
Expand Down

0 comments on commit eb68bd0

Please sign in to comment.