feat: Add native Comet ML experiment tracking#1411

Open

LoganVegnaSHOP wants to merge 38 commits intoNVIDIA-NeMo:mainfrom

LoganVegnaSHOP:feat/comet-logger

Commits on Mar 4, 2026

feat: support chat datasets in packed sequence THD collator
hemildesai
committed
test: add missing unit tests for data and CP changes
hemildesai
committed
fix: correct attention_mask for pre-padded input_ids in _package_tokenized_example

hemildesai
and
claude
committed
refactor: remove division-by-zero guards from this PR

hemildesai
and
claude
committed
docs: add comment explaining padding=False in format_chat_template

hemildesai
and
claude
committed
feat: shuffle HF datasets before slicing in chat dataset loader

hemildesai
and
claude
committed
feat: make shuffle seed configurable in ChatDataset

hemildesai
and
claude
committed
refactor: default shuffle_seed to None, set explicitly in yaml

hemildesai
and
claude
committed
fix: pop padding_mask from batch before passing to model forward

hemildesai
and
claude
committed
fix: accept **kwargs in GPT2LMHeadModel.forward for padding_mask

hemildesai
and
claude
committed
fix: stop stripping padding_mask from batch before model forward

hemildesai
and
claude
committed
fix: do not default split to "train" in _load_openai_messages

hemildesai
and
claude
committed
docs: fix comment about pre-padded input_ids source

hemildesai
and
claude
committed
docs: fix incorrect function name in comment

hemildesai
and
claude
committed
fix: do not append EOS to truncated sequences in format_chat_template

hemildesai
and
claude
committed
feat: resolve chat_template from file path in ChatDataset

hemildesai
and
claude
committed
fix: pass actual padding to apply_chat_template and support longest

hemildesai
and
claude
committed
fix: remove dataset-level longest padding resolution

hemildesai
and
claude
committed
fix: remove attention_mask from THD context parallelism path

hemildesai
and
claude
committed
fix: compute attention_mask content_length before next-token shift

hemildesai
and
claude
committed
fix: update functional tests for new padding behavior

hemildesai
and
claude
committed
feat: Add native Comet ML experiment tracking support
LoganVegnaSHOP
committed
test: Add unit tests for CometLogger (92% coverage)
LoganVegnaSHOP
committed
fix: Require comet.project_name instead of defaulting
LoganVegnaSHOP
committed
feat: add Qwen3 dense model handler for NeMo Automodel
LoganVegnaSHOP
committed
fix: remove **kwargs from Qwen3ForCausalLM to prevent config conflict
LoganVegnaSHOP
committed
fix: resolve CI linting and test failures
LoganVegnaSHOP
committed
fix: skip supervised-token assertion when truncation removes assistant

hemildesai
and
claude
committed
fix: remove eos_token_id assertions from pad-eos overlap tests

hemildesai
and
claude
committed

Commits on Mar 5, 2026

Commits on Mar 6, 2026