Open
Conversation
Signed-off-by: root <root@dgx-003.localdomain>
aasthajh
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
Contributor
|
/ok to test 09284e4 |
Contributor
|
Hi @chenopis , can you help us with a review? Thank you |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chenopis
suggested changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Documentation Review: Fine-Tuning Nemotron Parse v1.1 Tutorial
Reviewed for technical accuracy (cross-referenced against examples/vlm_finetune/nemotron/nemotron_parse_v1_1.yaml and CONTRIBUTING.md), code structure, and writing style.
Findings
| Severity | Count | Summary |
|---|---|---|
| High | 3 | Missing license header, wrong distributed config key, code duplication |
| Medium | 4 | Epoch math discrepancy, hardcoded GPU count, hyphenation, sentence fragment |
Clickable “Apply suggestion” blocks are provided where the fix is unambiguous (4 of 7 comments).
Review generated with AI assistance.
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Outdated
Show resolved
Hide resolved
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Outdated
Show resolved
Hide resolved
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Outdated
Show resolved
Hide resolved
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Outdated
Show resolved
Hide resolved
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Outdated
Show resolved
Hide resolved
examples/vlm_finetune/nemotron/parse-ft-tutorial/parse_finetune_tutorial.ipynb
Show resolved
Hide resolved
…e_tutorial.ipynb Co-authored-by: Andrew Chen <chenopis@users.noreply.github.com>
…e_tutorial.ipynb Co-authored-by: Andrew Chen <chenopis@users.noreply.github.com>
…et.py Co-authored-by: Andrew Chen <chenopis@users.noreply.github.com>
…e_tutorial.ipynb Co-authored-by: Andrew Chen <chenopis@users.noreply.github.com>
…U config - Import json2token from invoice_dataset.py instead of redefining it in the eval helpers cell (single source of truth) - Replace embedded DATASET_PY_CONTENT with shutil.copy of co-located file - Fix max_steps from 2000 to 530 to match actual 10-epoch training - Replace hardcoded CUDA_VISIBLE_DEVICES with dynamic GPU detection - Use NUM_GPUS variable in torchrun --nproc_per_node Signed-off-by: aasthajh <aasthaj@nvidia.com> Made-with: Cursor
Contributor
|
/ok to test 2a4574a |
Contributor
|
/ok to test e96fbdd |
Contributor
|
/ok to test 95a2d43 |
Contributor
|
Hi @NVIDIA-NeMo/automation, secrets detector reports false positives, please help us FM this. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding Nemotron Parse Fine Tuning tutorial
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.