-
Notifications
You must be signed in to change notification settings - Fork 218
[REVIEW] Benchmarking Script for E2E Pipeline #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VibhuJawa
merged 19 commits into
NVIDIA-NeMo:main
from
VibhuJawa:vjawa/add_benchmarking_scripts
Feb 4, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
96c887d
first working commit
VibhuJawa 5ec3aad
Merge branch 'NVIDIA-NeMo:main' into vjawa/add_benchmarking_scripts
VibhuJawa 5f570d5
Modified scripts based on feedback
VibhuJawa 1cd9e95
add stuff to nightly-benchmark.yaml
VibhuJawa 32dea05
add more custom metrics
VibhuJawa 8408990
Removed -45 limit
VibhuJawa 958d33e
Removed epilog (not useful)
VibhuJawa 683fa61
remove random -DEFAULT_FASTTEXT_MODEL_PATH
VibhuJawa 72b84d9
removed random if that added around fastai
VibhuJawa be0a328
removed the hard coding of arxiv path
VibhuJawa 53cc847
Add util requested in review
VibhuJawa ee8adb9
Add util
VibhuJawa 9a101d0
Merge branch 'main' into vjawa/add_benchmarking_scripts
VibhuJawa b81b2fe
Addressed reviews and ensure stuff is working
VibhuJawa 93fa49e
Merge branch 'main' into vjawa/add_benchmarking_scripts
VibhuJawa 0367625
added paths/dir
VibhuJawa ad9fafd
Merge branch 'main' into vjawa/add_benchmarking_scripts
VibhuJawa 75f7b5f
Merge branch 'main' into vjawa/add_benchmarking_scripts
VibhuJawa 3333ad3
Merge branch 'main' into vjawa/add_benchmarking_scripts
VibhuJawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the image and video models we do it like:
and
so do you think we should just do
path: "{datasets_path}/fasttext/lid.176.bin"to match?