docs: agent-assisted development plan for DataDesigner#428
Conversation
Plan for optimizing DataDesigner for agent-assisted development workflows, inspired by patterns from NVIDIA/OpenShell. Covers foundation document updates, GitHub machinery, skill infrastructure consolidation, and architecture documentation. Closes #427
Greptile SummaryThis PR adds Key observations:
|
| Filename | Overview |
|---|---|
| plans/427/agent-first-development-plan.md | Comprehensive agent-first development plan covering four phases (infrastructure consolidation, doc restructuring, GitHub machinery, future skills). Well-structured and internally consistent except for an unresolved classification of the new-sdg usage skill in the Phase 1b "label all skills as development" instruction. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
P0["Phase 0\nAGENTS.md restructure\n(~50 lines)"]
P1["Phase 1\nSkill & Agent Infrastructure\n(.agents/ consolidation,\n.claude/ symlinks, .codex/ symlinks)"]
P2A["Phase 2A\nSTYLEGUIDE.md +\nDEVELOPMENT.md\n(extracted from AGENTS.md)"]
P2B["Phase 2B\nCONTRIBUTING.md overhaul"]
P2C["Phase 2C\nREADME.md updates"]
P3["Phase 3 (parallelisable)\nIssue templates\nPR template\nCODEOWNERS\nLabels\narchitecture/ skeleton\nSkill template conformance"]
P4["Phase 4 (separate plan required)\nNew skills\nSub-agent personas\nIssue triage workflow"]
P0 --> P1
P0 --> P2A
P2A --> P2B
P2B --> P2C
P2C --> P3
P3 -.->|requires own planning pass| P4
Prompt To Fix All With AI
This is a comment left during a code review.
Path: plans/427/agent-first-development-plan.md
Line: 139-145
Comment:
**`new-sdg` classified incorrectly in Phase 1b**
Phase 1b directs that *every* skill file should have its description or frontmatter updated to identify it as a **development** skill. However, `new-sdg` is a usage skill — its own frontmatter reads `"Implement a new synthetic data generator using NeMo Data Designer by defining its configuration and executing a preview job."` and it is the exact kind of end-user usage tooling the plan distinguishes from development tooling (lines 13-18).
Labelling `new-sdg` as a development skill would contradict the plan's own stated goal of keeping the two surfaces clearly separate so agents don't confuse contributor work with dataset-building workflows.
The plan also does not say where `new-sdg` should live after the Phase 1 consolidation. If `.agents/skills/` is meant to be a **development-only** canonical path (which the framing strongly implies), then `new-sdg` either needs its own designated location or the plan needs an explicit note carving it out from the "label all skills as development" instruction and specifying its destination.
How can I resolve this? If you propose a fix, please make it concise.Reviews (6): Last reviewed commit: "Merge branch 'main' into nmulepati/docs/..." | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Incorporate johnnygreco's review comments from PR #428: - Distinguish development tooling vs usage tooling throughout - Promote AGENTS.md restructure to Phase 0 (~50 lines target) - Remove skills inventory, workflows, and conventions from AGENTS.md scope - Remove new-sdg from skill categories (repo skills = development only) - Overhaul CONTRIBUTING.md toward plan-submission-via-issues workflow - Tone down README agent-first messaging to 1-2 sentences - Simplify CODEOWNERS to single maintainer group - Resolve 4 of 5 open questions per reviewer answers - Fix malformed markdown and Out of Scope contradiction - Add AGENTS.md redirect for dataset-building agents - Tag skills as development-scoped in metadata Made-with: Cursor
johnnygreco
left a comment
There was a problem hiding this comment.
Thanks @nabinchha!! Can't for this to land 🚀
Summary
Adds a comprehensive development plan for introducing agent-assisted workflows into DataDesigner, inspired by NVIDIA/OpenShell. The plan covers infrastructure consolidation, documentation restructuring, and GitHub machinery updates across four phases.
Related Issue
Closes #427
Changes
plans/427/agent-first-development-plan.mdwith:.agents/as a tool-agnostic canonical path, with symlinks for.claude/and.codex/compatibilityAGENTS.mdinto focused files (STYLEGUIDE.md,DEVELOPMENT.md), updateREADME.mdandCONTRIBUTING.mdto advertise agent workflows, createarchitecture/skeletonCODEOWNERS, create label taxonomy