Skip to content

ci: Fix sso user check#137

Merged
chtruong814 merged 1 commit intomainfrom
chtruong/fix-sso
Mar 19, 2026
Merged

ci: Fix sso user check#137
chtruong814 merged 1 commit intomainfrom
chtruong/fix-sso

Conversation

@chtruong814
Copy link
Contributor

ci: Fix sso user check

The file name we used to check if a user is internal or not changed. Updating the workflow to pass in the file name via a Github variable so we can change it later if needed.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Contributor Author

Fast merging this to ensure CI is working as expected.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 19, 2026

Greptile Summary

This PR fixes the SSO (internal user) check in the CICD workflow by passing the SSO users filename as a configurable GitHub Actions variable (vars.SSO_USERS_FILENAME) to the reusable _cicd_preflight workflow. It also pins the reusable workflow reference from the floating @main tag to the explicit @v0.80.1 tag.

  • The new sso_users_filename input allows the SSO filename to be updated via the repository's GitHub Actions variable settings without needing a code change — a clean operational improvement.
  • Pinning to @v0.80.1 ensures deterministic behavior and prevents unintended breaking changes from upstream updates; this is likely also necessary to pick up the version that added support for the sso_users_filename input.
  • If the SSO_USERS_FILENAME repository variable is not configured in GitHub Actions settings, the input will be passed as an empty string. Ensure this variable is set in the repository's Actions variables before merging.

Confidence Score: 5/5

  • This PR is safe to merge, provided the SSO_USERS_FILENAME Actions variable is configured in the repository settings.
  • The change is minimal (3 lines), targeted, and well-described. Pinning to a specific version is a best practice for reusable workflows, and externalising the filename to a GitHub variable is a clean approach. The only prerequisite is that the SSO_USERS_FILENAME repository variable must be set before this workflow runs, which is an operational step outside the code itself.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/cicd-main.yml Pins the reusable _cicd_preflight workflow to v0.80.1 (previously @main) and adds a new sso_users_filename input sourced from vars.SSO_USERS_FILENAME to fix the SSO user identity check. Both changes are correct and intentional.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant PF as pre-flight<br/>(_cicd_preflight@v0.80.1)
    participant CI as cicd-wait-in-queue /<br/>cicd-container-build
    participant UT as cicd-unit-tests

    GH->>PF: Trigger with inputs:<br/>default_runner_prefix<br/>non_nvidia_runner_prefix<br/>default_test_data_path<br/>non_nvidia_test_data_path<br/>sso_users_filename (NEW)
    PF->>PF: Check if user is internal<br/>using sso_users_filename
    PF-->>GH: Outputs: is_ci_workload,<br/>docs_only, runner_prefix, etc.
    GH->>CI: Trigger (needs: pre-flight)
    GH->>UT: Trigger (needs: pre-flight, cicd-container-build)
Loading

Last reviewed commit: "ci: Fix sso user che..."

@chtruong814 chtruong814 merged commit 250f140 into main Mar 19, 2026
9 checks passed
@chtruong814 chtruong814 deleted the chtruong/fix-sso branch March 19, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant