Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
Fast merging this to ensure CI is working as expected. |
Contributor
Greptile SummaryThis PR fixes the SSO (internal user) check in the CICD workflow by passing the SSO users filename as a configurable GitHub Actions variable (
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant PF as pre-flight<br/>(_cicd_preflight@v0.80.1)
participant CI as cicd-wait-in-queue /<br/>cicd-container-build
participant UT as cicd-unit-tests
GH->>PF: Trigger with inputs:<br/>default_runner_prefix<br/>non_nvidia_runner_prefix<br/>default_test_data_path<br/>non_nvidia_test_data_path<br/>sso_users_filename (NEW)
PF->>PF: Check if user is internal<br/>using sso_users_filename
PF-->>GH: Outputs: is_ci_workload,<br/>docs_only, runner_prefix, etc.
GH->>CI: Trigger (needs: pre-flight)
GH->>UT: Trigger (needs: pre-flight, cicd-container-build)
Last reviewed commit: "ci: Fix sso user che..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: Fix sso user check
The file name we used to check if a user is internal or not changed. Updating the workflow to pass in the file name via a Github variable so we can change it later if needed.