Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Greptile SummaryThis PR updates Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant CI as cicd-nightly-tests
participant Action as test-template/action.yml
participant Container as Docker Container
participant Script as L1_Tests_GPU.sh
participant Coverage as coverage tool
CI->>Action: invoke with script=L1_Tests_GPU
Action->>Container: docker run (GPU)
Action->>Container: bash tests/ci/L1_Tests_GPU.sh
Container->>Script: execute
Script->>Container: mkdir -p test-results/tests/convergence
loop for each *_test.py in tests/convergence/
Script->>Coverage: coverage run -p --source=emerging_optimizers <test> --seed=77 --xml_output_file=...
Coverage->>Container: writes .coverage.<pid> partial file
Coverage->>Container: writes test-results/tests/convergence/*_seed77.xml
end
Action->>Container: coverage combine (merges .coverage.* files)
Action->>Container: coverage xml
Action->>CI: upload .coverage + coverage.xml artifacts
Action->>CI: upload test-results/**/*.xml artifacts
Reviews (1): Last reviewed commit: "enable coverage for l1 tests" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that it doesn't fail on coverage collection steps.