feat: Add container runtime (podman as new runtime)#741
Open
feat: Add container runtime (podman as new runtime)#741
Conversation
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
wprazuch
force-pushed
the
wprazuch/podman-runtime
branch
from
c9134db to
a53dad6
Compare
Contributor
Author
|
/ok to test a53dad6 |
Contributor
Author
|
/ok to test a75dc0e |
Contributor
Author
|
/ok to test d0df7b1 |
- Merge main (3856241) into wprazuch/podman-runtime - Resolve conflicts in executor.py (keep ContainerRuntime + add env_vars imports and secrets handling from main) and run.template.sh (keep $RUNTIME variable while adding reexport_cmd blocks from main) - Add test_container_runtime.py: 14 unit tests for ContainerRuntime that mock shutil.which, so they run in CI without docker or podman installed - Patch ContainerRuntime in test_local_executor.py dry-run tests to prevent RuntimeError in environments without docker/podman Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
wprazuch
force-pushed
the
wprazuch/podman-runtime
branch
from
d0df7b1 to
9670cfc
Compare
Contributor
Author
|
/ok to test 9670cfc |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Contributor
Author
|
/ok to test d44fb0a |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Contributor
Author
|
/ok to test d3cf2b4 |
Contributor
Author
|
/ok to test 6e4cd6a |
test_telemetry.py and test_example_configs.py called LocalExecutor.execute_eval() without mocking ContainerRuntime, causing failures in CI where docker/podman are not available. - Add mock_container_runtime fixture to conftest.py - Apply @pytest.mark.usefixtures to TestExampleConfigs - Patch ContainerRuntime in the two failing TestLocalExecutorTelemetryPropagation tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
This reverts commit a1435ea. Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
…e baseline line numbers The detect-secrets baseline tracks hex strings at lines 509/530 in conftest.py. Inserting the fixture earlier shifted them, causing the secrets detector to fail. Moving the fixture to the end of the file keeps existing line numbers stable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Contributor
Author
|
/ok to test 7907c85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.