Skip to content

fix(tests): Remove temp files created in aiperf unit-tests #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pouyanpi merged 2 commits into from
Dec 12, 2025
Merged

fix(tests): Remove temp files created in aiperf unit-tests #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a20bed8
Use temporary path as default value in AIperf tests
tgasser-nv Dec 11, 2025
bed6480
Revert type fix that's needed locally but breaks on the server
tgasser-nv Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/benchmark/test_run_aiperf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@


@pytest.fixture
def create_config_data():
def create_config_data(tmp_path):
"""Returns a function with sample basic config, and allows mutation of fields to cover
more cases or add extra fields"""

def _create_config(
batch_name="test_batch",
output_base_dir="test_output",
output_base_dir=str(tmp_path),
model="test-model",
tokenizer="test-tokenizer",
url="http://localhost:8000",
Expand Down Expand Up @@ -125,7 +125,7 @@ def test_init_with_valid_config(self, create_config_file):
assert runner.config_path == config_file
assert isinstance(runner.config, AIPerfConfig)
assert runner.config.batch_name == "test_batch"
assert runner.config.output_base_dir == "test_output"
assert runner.config.output_base_dir == str(config_file.parent)
assert runner.config.base_config.model == "test-model"
assert runner.config.base_config.tokenizer == "test-tokenizer"
assert runner.config.base_config.url == "http://localhost:8000"
Expand Down