-
Notifications
You must be signed in to change notification settings - Fork 60
pypi compatibility #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
pypi compatibility #649
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
56fc579 to
e4e9c9e
Compare
| branches: | ||
| - main | ||
| - "r**" | ||
| - cmunley1/pypi-compat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed after testing on this branch is done
|
|
||
| verbose_flag = "-v " if global_config_dict.get(PIP_INSTALL_VERBOSE_KEY_NAME) else "" | ||
|
|
||
| # TEMPORARY: need to specify test-pypi index until its published to pypi.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed when we are ready to push to pypi (not test pypi)
nemo_gym/cli.py
Outdated
| # install nemo-gym from pypi instead of relative path in pyproject.toml | ||
| install_cmd = ( | ||
| f"""uv pip install {verbose_flag}{uv_pip_python_flag}{pypi_index_flags}nemo-gym && """ | ||
| f"""sed -i '/\\[tool.uv.sources\\]/,/^$/d' pyproject.toml && """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont really like this, sed to remove this block of vllm_model pyproject.toml, but it was error otherwise. could cause trouble if we needed tool uv sources for something else in vllm-model, but i doubt that happens.
I feel in general this runtime server deps patching is not ideal and we should have a different longer-term solution (like reorganize all under nemo_gym might solve this)
|
to test: |
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
env.yamland for config paths provided tong_run.importlib.metadataforng_helpbasic tests done of
ng_runandng_collect_rolloutswith an environment outside ofGym/.I think that we should really consider a few things, but maybe we stick to minimal changes for now:
site-packages/resources_servers