Skip to content

Conversation

@cmunley1
Copy link
Contributor

@cmunley1 cmunley1 commented Feb 5, 2026

  • search cwd for env.yaml and for config paths provided to ng_run.
  • use importlib.metadata for ng_help
  • modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path

basic tests done of ng_run and ng_collect_rollouts with an environment outside of Gym/.

I think that we should really consider a few things, but maybe we stick to minimal changes for now:

  • packaging environments separately
  • moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have site-packages/resources_servers
  • giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
branches:
- main
- "r**"
- cmunley1/pypi-compat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed after testing on this branch is done


verbose_flag = "-v " if global_config_dict.get(PIP_INSTALL_VERBOSE_KEY_NAME) else ""

# TEMPORARY: need to specify test-pypi index until its published to pypi.org
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed when we are ready to push to pypi (not test pypi)

nemo_gym/cli.py Outdated
# install nemo-gym from pypi instead of relative path in pyproject.toml
install_cmd = (
f"""uv pip install {verbose_flag}{uv_pip_python_flag}{pypi_index_flags}nemo-gym && """
f"""sed -i '/\\[tool.uv.sources\\]/,/^$/d' pyproject.toml && """
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont really like this, sed to remove this block of vllm_model pyproject.toml, but it was error otherwise. could cause trouble if we needed tool uv sources for something else in vllm-model, but i doubt that happens.

I feel in general this runtime server deps patching is not ideal and we should have a different longer-term solution (like reorganize all under nemo_gym might solve this)

@cmunley1 cmunley1 requested a review from chtruong814 February 10, 2026 02:12
@cmunley1
Copy link
Contributor Author

to test:
uv pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ nemo-gym==0.2.9172rc0 , create local resources server (just copy paste one out of Gym and change name), and run rollouts.

Signed-off-by: Christian Munley <[email protected]>
Signed-off-by: Christian Munley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant