Skip to content

dsv3 no_non_det_algo#2673

Open
malay-nagda wants to merge 1 commit intor0.3.0from
malay/no_non_det_algo
Open

dsv3 no_non_det_algo#2673
malay-nagda wants to merge 1 commit intor0.3.0from
malay/no_non_det_algo

Conversation

@malay-nagda
Copy link
Collaborator

@malay-nagda malay-nagda commented Mar 6, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Optimized performance settings for deepseek models to improve handling and behavior.

Signed-off-by: Malay Nagda <malayn@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 6, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@malay-nagda malay-nagda marked this pull request as ready for review March 6, 2026 14:35
@malay-nagda malay-nagda requested a review from ko3n1g March 6, 2026 14:36
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1d57a07-a45a-40c4-8d1b-a0ea97ba807a

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1ebe6 and eac20c2.

📒 Files selected for processing (1)
  • scripts/performance/perf_plugins.py

📝 Walkthrough

Walkthrough

Adds a new environment variable configuration for the deepseek model family in the performance plugin script. Sets NVTE_ALLOW_NONDETERMINISTIC_ALGO to "0" when model_family_name is "deepseek" alongside existing model-specific environment variable settings.

Changes

Cohort / File(s) Summary
Deepseek Model Configuration
scripts/performance/perf_plugins.py
Add environment variable assignment for deepseek model family to set NVTE_ALLOW_NONDETERMINISTIC_ALGO to "0".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

bug, r0.3.0

Suggested reviewers

  • dingqingy-nv
  • ko3n1g
  • erhoo82
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'dsv3 no_non_det_algo' is vague and uses abbreviated/cryptic terms that don't clearly convey the actual change: setting NVTE_ALLOW_NONDETERMINISTIC_ALGO to '0' for deepseek models. Use a more descriptive title like 'Set NVTE_ALLOW_NONDETERMINISTIC_ALGO=0 for deepseek models' to clearly summarize the primary change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Test Results For Major Changes ✅ Passed PR contains only a minor, targeted change adding a conditional block to set an environment variable for DeepSeek models, satisfying the pass condition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch malay/no_non_det_algo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant