Skip to content

chore: Bump MCore (main) 2026-03-10 — replaces conflicting #2719#2738

Closed
mehraakash wants to merge 2 commits intomainfrom
fix/mcore-bump-2026-03-10
Closed

chore: Bump MCore (main) 2026-03-10 — replaces conflicting #2719#2738
mehraakash wants to merge 2 commits intomainfrom
fix/mcore-bump-2026-03-10

Conversation

@mehraakash
Copy link
Contributor

@mehraakash mehraakash commented Mar 11, 2026

Summary

Replaces conflicting bump PR #2719 which could not be merged due to conflicts in 3rdparty/Megatron-LM and uv.lock.

What changed

  • Updates 3rdparty/Megatron-LM from 8318b8093e7d0e19bf11f704 (8 new MCore commits)
  • uv.lock unchanged — transformers is already pinned to 5.2.0 via pyproject.toml constraint <=5.2.0

New MCore commits

Closes #2719

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated dependencies with no functional changes to user-facing features.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

📝 Walkthrough

Walkthrough

Updates the 3rdparty/Megatron-LM submodule pointer to reference a newer commit version, aligning with dependency management changes tracked in the linked issue.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/Megatron-LM
Submodule commit pointer updated from 8318b80 to 0e19bf1; no functional code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: bumping MCore (Megatron-LM submodule) with a specific date, and references the replacement of conflicting PR #2719.
Linked Issues check ✅ Passed The PR addresses the linked issue #2719 by resolving conflicts and updating both 3rdparty/Megatron-LM and maintaining uv.lock consistency as intended by the original issue.
Out of Scope Changes check ✅ Passed The changes are limited to updating the Megatron-LM submodule pointer, which is directly in scope for the bumping objective stated in the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed This PR contains only a submodule pointer update with no functional code changes, as explicitly stated in the PR description indicating no impact to user-facing functionality. Test results documentation is only required for major changes such as new features, breaking changes, or refactoring, which do not apply here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mcore-bump-2026-03-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: Update the .main.commit file so it matches the new submodule commit
for 3rdparty/Megatron-LM (change the pinned hash from
8318b8093e7d49bce2529a29a14aeb50e5840ee0 to
0e19bf11f70483c18f058faff3d388186437fa30); scripts/switch_mcore.sh relies on
.main.commit as the source of truth so ensure the file contains the new hash
string exactly to keep local tooling from reverting the submodule to the old
MCore revision.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4b015eb2-82a9-4cf6-b3ea-3e5c74e743e3

📥 Commits

Reviewing files that changed from the base of the PR and between de93536 and 8367eaa.

📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 8318b8093e7d49bce2529a29a14aeb50e5840ee0
Subproject commit 0e19bf11f70483c18f058faff3d388186437fa30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update .main.commit alongside this submodule bump.

This moves 3rdparty/Megatron-LM to 0e19bf11f70483c18f058faff3d388186437fa30, but .main.commit still pins 8318b8093e7d49bce2529a29a14aeb50e5840ee0. scripts/switch_mcore.sh treats .main.commit as the source of truth, so leaving it unchanged means local tooling/automation can still reset main back to the old MCore revision. Please update .main.commit in the same PR to keep the pin consistent with the checked-in submodule state.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, Update the .main.commit file so it matches
the new submodule commit for 3rdparty/Megatron-LM (change the pinned hash from
8318b8093e7d49bce2529a29a14aeb50e5840ee0 to
0e19bf11f70483c18f058faff3d388186437fa30); scripts/switch_mcore.sh relies on
.main.commit as the source of truth so ensure the file contains the new hash
string exactly to keep local tooling from reverting the submodule to the old
MCore revision.

@yaoyu-33 yaoyu-33 added area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer and removed t-dependencies labels Mar 11, 2026
@mehraakash mehraakash force-pushed the fix/mcore-bump-2026-03-10 branch from 8367eaa to 3c3f183 Compare March 11, 2026 05:41
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

mehraakash and others added 2 commits March 10, 2026 23:20
Signed-off-by: Akash Mehra <akamehra@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Akash Mehra <akamehra@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mehraakash mehraakash force-pushed the fix/mcore-bump-2026-03-10 branch from 3c3f183 to 802d86a Compare March 11, 2026 06:20
@yaoyu-33
Copy link
Contributor

Closing as stale.

@yaoyu-33 yaoyu-33 closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants