chore: Bump MCore (main) 2026-03-10 — replaces conflicting #2719#2738
chore: Bump MCore (main) 2026-03-10 — replaces conflicting #2719#2738mehraakash wants to merge 2 commits intomainfrom
Conversation
4db5c00 to
8367eaa
Compare
📝 WalkthroughWalkthroughUpdates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: Update the .main.commit file so it matches the new submodule commit
for 3rdparty/Megatron-LM (change the pinned hash from
8318b8093e7d49bce2529a29a14aeb50e5840ee0 to
0e19bf11f70483c18f058faff3d388186437fa30); scripts/switch_mcore.sh relies on
.main.commit as the source of truth so ensure the file contains the new hash
string exactly to keep local tooling from reverting the submodule to the old
MCore revision.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4b015eb2-82a9-4cf6-b3ea-3e5c74e743e3
📒 Files selected for processing (1)
3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit 8318b8093e7d49bce2529a29a14aeb50e5840ee0 | |||
| Subproject commit 0e19bf11f70483c18f058faff3d388186437fa30 | |||
There was a problem hiding this comment.
Update .main.commit alongside this submodule bump.
This moves 3rdparty/Megatron-LM to 0e19bf11f70483c18f058faff3d388186437fa30, but .main.commit still pins 8318b8093e7d49bce2529a29a14aeb50e5840ee0. scripts/switch_mcore.sh treats .main.commit as the source of truth, so leaving it unchanged means local tooling/automation can still reset main back to the old MCore revision. Please update .main.commit in the same PR to keep the pin consistent with the checked-in submodule state.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, Update the .main.commit file so it matches
the new submodule commit for 3rdparty/Megatron-LM (change the pinned hash from
8318b8093e7d49bce2529a29a14aeb50e5840ee0 to
0e19bf11f70483c18f058faff3d388186437fa30); scripts/switch_mcore.sh relies on
.main.commit as the source of truth so ensure the file contains the new hash
string exactly to keep local tooling from reverting the submodule to the old
MCore revision.
8367eaa to
3c3f183
Compare
Signed-off-by: Akash Mehra <akamehra@nvidia.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Akash Mehra <akamehra@nvidia.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3c3f183 to
802d86a
Compare
|
Closing as stale. |
Summary
Replaces conflicting bump PR #2719 which could not be merged due to conflicts in
3rdparty/Megatron-LManduv.lock.What changed
3rdparty/Megatron-LMfrom8318b8093e7d→0e19bf11f704(8 new MCore commits)uv.lockunchanged —transformersis already pinned to5.2.0viapyproject.tomlconstraint<=5.2.0New MCore commits
0e19bf11Add CP + Sequence Packing support for Mimo ([sync] FP8 params support for megatron-fsdp (MXFP8/Blockwise) #2135)ce66b222Update copy-pr-bot.yaml [skip ci]94ff0dc6Check reviews properly (#3756)d904a683Re-enable tests which were failing on #3373 (#3757)452fc115Update README Quick Start (#3596)56158bbdrevert of Override moe_token_dispatcher_type to "alltoall" when export megatron… #2658 (#3736)116a7fa3Claude: run actions on target branch (#3745)597721a1chore(beep boop): Bump (main) (2026-03-09)Closes #2719
🤖 Generated with Claude Code
Summary by CodeRabbit