-
Notifications
You must be signed in to change notification settings - Fork 248
chore: bump torch 2.9.1, vllm 0.15 sglang 0.5.8, ray 2.53 #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Terry Kong <terryk@nvidia.com>
📝 WalkthroughWalkthroughThis PR updates core Python package dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 22-25: The build-group entry pins "torch==2.9.0" while the runtime
dependencies list "torch==2.9.1", causing an ABI mismatch; update the
build-group torch pin from "torch==2.9.0" to "torch==2.9.1" so both build and
runtime use the exact same torch version (look for the "torch==2.9.0" string in
the build-group section of pyproject.toml and replace it with "torch==2.9.1").
🧹 Nitpick comments (1)
pyproject.toml (1)
294-335: Clean up or gate remaining sgl-kernel config after disabling it.
sgl-kernelis now commented out in extra-build-dependencies and dependency-metadata, butextra-build-variablesstill defines sgl-kernel settings (Line 215). Consider removing or gating those entries to avoid stale config and confirm sglang no longer requires sgl-kernel at build/runtime.
Signed-off-by: Terry Kong <terryk@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
blocked by #1787 (plan is to update mbridge first to unblock nano and then merge this)
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit