Add nsys command argument to profile cuda graph workload#138
Merged
hemildesai merged 3 commits intoNVIDIA-NeMo:mainfrom Jan 23, 2025
Merged
Add nsys command argument to profile cuda graph workload#138hemildesai merged 3 commits intoNVIDIA-NeMo:mainfrom
hemildesai merged 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
added 2 commits
January 21, 2025 10:01
…ofile export path Signed-off-by: Guyue Huang <guyueh@login-preos02.a51.clusters.nvidia.com>
Signed-off-by: Guyue Huang <guyueh@login-preos02.a51.clusters.nvidia.com>
Contributor
Author
|
I reverted change 2 since the issue is fixed in main; Only keep change 1. |
hemildesai
previously approved these changes
Jan 22, 2025
Contributor
Author
|
What else is needed for this PR, could you trigger workflows? @hemildesai |
Contributor
Sorry didn't realize I had to approve. Looks like a test failed, but should be a one line fix. Can you push the fix? I'll reapprove and merge after. |
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Contributor
Author
|
I pushed a fix to the test. |
hemildesai
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two changes
--cuda-graph-trace=nodeto allow nsys to see into cuda graph replays