Skip to content

Remove unnecessary runner.status call in launcher#156

Merged
hemildesai merged 1 commit intomainfrom
hemil/opt-launcher
Feb 15, 2025
Merged

Remove unnecessary runner.status call in launcher#156
hemildesai merged 1 commit intomainfrom
hemil/opt-launcher

Conversation

@hemildesai
Copy link
Contributor

Thanks to @titu1994 for the finding. Feel free to comment your analysis here.

Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai hemildesai requested a review from titu1994 February 15, 2025 17:33
@titu1994
Copy link
Contributor

titu1994 commented Feb 15, 2025

Can confirm, job submission on my machine with this patch is now roughly 7x faster.
For 40 independent jobs x 7 dependent runs = 280 total jobs
Before - 28 minutes
After - 4 min 15 sec

There is a somewhat fixed one time cost of 35 sec overhead for the exp.add(), but after that exp.run() takes roughly < 0.5 sec per job, far faster than the earlier variable 6-7 seconds per job

Copy link
Contributor

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@hemildesai hemildesai merged commit 451f781 into main Feb 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants