Remove unnecessary runner.status call in launcher#156
Merged
hemildesai merged 1 commit intomainfrom Feb 15, 2025
Merged
Conversation
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Contributor
|
Can confirm, job submission on my machine with this patch is now roughly 7x faster. There is a somewhat fixed one time cost of 35 sec overhead for the exp.add(), but after that exp.run() takes roughly < 0.5 sec per job, far faster than the earlier variable 6-7 seconds per job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @titu1994 for the finding. Feel free to comment your analysis here.