Skip to content

Catch errors when loading external main in fdl_runner #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemildesai merged 1 commit into from
Mar 4, 2025
Merged

Catch errors when loading external main in fdl_runner #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/nemo_run/core/runners/fdl_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import logging

import typer

fdl_runner_app = typer.Typer(pretty_exceptions_enable=False)
Expand Down Expand Up @@ -49,7 +51,11 @@ def fdl_direct_run(
fdl_package.setup()

if os.path.isfile(fdl_config):
maybe_load_external_main(Path(fdl_config).parent.parent.parent)
try:
maybe_load_external_main(Path(fdl_config).parent.parent.parent)
except Exception as e:
logging.warning(f"Failed to load external main: {e}")

fdl_config = Path(fdl_config).read_text()

fdl_buildable: fdl.Buildable = ZlibJSONSerializer().deserialize(fdl_config)
Expand Down
Loading