Add error handling for executor deserialization in dgxcloud scheduler…#167
Closed
pablo-garay wants to merge 7 commits intohemil/fix-dgxc-serdefrom
Closed
Add error handling for executor deserialization in dgxcloud scheduler…#167pablo-garay wants to merge 7 commits intohemil/fix-dgxc-serdefrom
pablo-garay wants to merge 7 commits intohemil/fix-dgxc-serdefrom
Conversation
…#166) Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
* refactor: Improve packaging job handling in SlurmExecutor - Add `get_packaging_job_key()` to generate unique packaging job keys using experiment ID - Update packaging job tracking to use experiment-specific keys - Modify packaging job deserialization to handle legacy dictionary format - Enhance experiment initialization with optional component defaults - Improve tunnel scheduler initialization with optional experiment context This refactoring ensures more robust and flexible packaging job management across different execution contexts. Signed-off-by: Hemil Desai <hemild@nvidia.com> * fix Signed-off-by: Hemil Desai <hemild@nvidia.com> * ruff format fix Signed-off-by: Hemil Desai <hemild@nvidia.com> --------- Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
* ci(feat): Onboard codecov Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> --------- Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#166)