refactor: Improve packaging job handling in SlurmExecutor#171
Merged
hemildesai merged 3 commits intomainfrom Mar 11, 2025
Merged
refactor: Improve packaging job handling in SlurmExecutor#171hemildesai merged 3 commits intomainfrom
hemildesai merged 3 commits intomainfrom
Conversation
- Add `get_packaging_job_key()` to generate unique packaging job keys using experiment ID - Update packaging job tracking to use experiment-specific keys - Modify packaging job deserialization to handle legacy dictionary format - Enhance experiment initialization with optional component defaults - Improve tunnel scheduler initialization with optional experiment context This refactoring ensures more robust and flexible packaging job management across different execution contexts. Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
titu1994
approved these changes
Mar 10, 2025
Contributor
|
Is the uv lock part of this pr ? Otherwise looks good ! |
Contributor
Author
That's just an update to the dependency lockfile that got outdated. Should be safe. |
Kipok
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: For relevant diff see 8216055
get_packaging_job_key()to generate unique packaging job keys using experiment IDThis refactoring ensures more robust and flexible packaging job management across different execution contexts.