Skip to content

Fix docker scheduler creation #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemildesai merged 1 commit into from
Mar 11, 2025
Merged

Fix docker scheduler creation #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions nemo_run/run/torchx_backend/schedulers/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import os
from datetime import datetime
from pathlib import Path
from typing import Iterable, Optional
from typing import Any, Iterable, Optional

from torchx.schedulers.api import (
AppDryRunInfo,
Expand Down Expand Up @@ -272,9 +272,7 @@ def __del__(self) -> None:
)


def create_scheduler(
session_name: str,
) -> PersistentDockerScheduler:
def create_scheduler(session_name: str, **kwargs: Any) -> PersistentDockerScheduler:
return PersistentDockerScheduler(
session_name=session_name,
)
Loading