Add --cuda-event-trace=false to nsys command#180
Merged
hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom Apr 8, 2025
Merged
Add --cuda-event-trace=false to nsys command#180hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom
hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
hemildesai
reviewed
Mar 23, 2025
Contributor
hemildesai
left a comment
There was a problem hiding this comment.
Is it possible to extract all these args to a nsys_extra_args attr on the Launcher? This way it will become configurable and will be easier in the future to add/remove args.
Contributor
Author
@hemildesai I put the nsys arguments to a variable named |
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
9d0ff6b to
88e2fa5
Compare
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
hemildesai
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should only be used with a recent nsys version.