Improve WSL & Windows compatibility for SSH tunnels and editors#210
Closed
oliverholworthy wants to merge 11 commits intoNVIDIA-NeMo:mainfrom
Closed
Improve WSL & Windows compatibility for SSH tunnels and editors#210oliverholworthy wants to merge 11 commits intoNVIDIA-NeMo:mainfrom
oliverholworthy wants to merge 11 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
oliverholworthy
had a problem deploying
to
public
GitHub Actions
Failure
oliverholworthy
had a problem deploying
to
public
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/devspace/test_editor.py
Outdated
| @@ -0,0 +1,163 @@ | |||
| import os | |||
| import platform | |||
| import subprocess | |||
Check notice
Code scanning / CodeQL
Unused import Note test
test/devspace/test_editor.py
Outdated
| import pytest | ||
| from pathlib import Path | ||
| import shutil | ||
| from unittest.mock import patch, MagicMock |
Check notice
Code scanning / CodeQL
Unused import Note test
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>
Contributor
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Contributor
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances compatibility with Windows and Windows Subsystem for Linux (WSL) environments by addressing several issues:
SSH Tunneling Improvements
as_posix()in tunnel server codeEditor Support Enhancements
Testing & Dependencies
This allows users on any platform to seamlessly use SSH tunnels and launch editors, particularly improving the experience for those using WSL.