Skip to content

Fixes for multi-node execution with torchrun + LocalExecutor in Slurm environment #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 1 commit into from
Jul 19, 2025
Merged

Fixes for multi-node execution with torchrun + LocalExecutor in Slurm environment #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nemo_run/run/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,10 @@ def run(
return

# Prepare experiment before running
self._prepare()

# in case of multi-node execution with LocalExecutor+torchrun+slurm, run only on first rank
if int(os.getenv("SLURM_PROCID", 0)) == 0:
self._prepare()

if direct:
self.console.log(
Expand Down
3 changes: 3 additions & 0 deletions nemo_run/run/torchx_backend/components/torchrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,11 @@ def torchrun(
num_nodes = nnodes_rep
nproc_per_node = str(nproc_per_node)

# set node rank to relative node id in the current allocation
if use_env and os.getenv("NODE_RANK"):
node_rank = os.environ["NODE_RANK"]
elif use_env and os.getenv("SLURM_NODEID"):
node_rank = os.environ["SLURM_NODEID"]
else:
node_rank = torchx_dist._noquote(f"$${ExecutorMacros.NODE_RANK_VAR}")

Expand Down
Loading