Skip to content

[Bugfix - LeptonExecutor] Setting names to be lowercase and shortened for length #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roclark merged 1 commit into from
Jun 24, 2025
Merged

[Bugfix - LeptonExecutor] Setting names to be lowercase and shortened for length #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nemo_run/core/execution/lepton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,10 @@

def launch(self, name: str, cmd: list[str]) -> tuple[str, str]:
self._validate_mounts()
name = name.replace("_", "-").replace(".", "-") # to meet K8s requirements
name = name.replace("_", "-").replace(".", "-").lower() # to meet K8s requirements

Check warning on line 243 in nemo_run/core/execution/lepton.py

View check run for this annotation

Codecov / codecov/patch

nemo_run/core/execution/lepton.py#L243 

Added line #L243 was not covered by tests
if len(name) > 35:
logger.warning("length of name exceeds 35 characters. Shortening...")
name = name[:34]

Check warning on line 246 in nemo_run/core/execution/lepton.py

View check run for this annotation

Codecov / codecov/patch

nemo_run/core/execution/lepton.py#L245-L246 

Added lines #L245 - L246 were not covered by tests
launch_script = f"""
wget -O init.sh https://raw.githubusercontent.com/leptonai/scripts/main/lepton_env_to_pytorch.sh
chmod +x init.sh
Expand Down
Loading