misc fixes

[akoumpa]

Changes:

• guard env appending if env is none
• make goodbye message optional
• write sbatch script if not already written

The main issue I faced was not getting the sbatch script written, i used something like the following code

    executor = run.SlurmExecutor(**slurm_config, tunnel=run.LocalTunnel(job_dir=job_dir))
    run_name = 'exp_name'
    with run.Experiment('exp', goodbye_message=False) as exp:
        exp.add(
            run.Script(
                path=script_path,
                args=[
                    "--config",
                    config_file,
                ],
                env=container_env,
                entrypoint="python",
            ),
            executor=executor,
            name=run_name[:37],  # DGX-C run name length limit
            tail_logs=False,
        )
        exp.run(sequential=True, detach=True, tail_logs=False)

To fix the issue, the return statement should be moved outside the finally block. This ensures that exceptions raised during the execution of the try block or the finally block are not suppressed. The cleanup operations in the finally block will still execute, but the exception will propagate correctly.

The best approach is to refactor the __exit__ method to store the return value in a variable and return it after the finally block. This preserves the intended functionality while ensuring proper exception handling.

---