add a grace for Jobs that may start in Unknown#291
Merged
roclark merged 5 commits intoNVIDIA-NeMo:mainfrom Aug 22, 2025
Merged
Conversation
Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com>
Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com>
Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com>
zoeyz101
previously approved these changes
Jul 15, 2025
Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com>
Signed-off-by: prekshivyas <prekhsivyas@gmail.com>
Contributor
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Contributor
Author
|
comment to remove stale |
roclark
approved these changes
Aug 22, 2025
Contributor
roclark
left a comment
roclark
left a comment
There was a problem hiding this comment.
LGTM, thanks for putting this together!
zoeyz101
pushed a commit
to zoeyz101/NeMo-Run
that referenced
this pull request
Nov 12, 2025
* add a grace for Jobs that may start in Unknown Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com> * add a grace for Jobs that may start in Unknown Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com> * add a grace for Jobs that may start in Unknown Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com> * fix linting Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com> * make the handling of Unknown job status better by polling Signed-off-by: prekshivyas <prekhsivyas@gmail.com> --------- Signed-off-by: Prekshi Vyas <prekshivyas@gmail.com> Signed-off-by: prekshivyas <prekhsivyas@gmail.com> Co-authored-by: prekshivyas <prekhsivyas@gmail.com> Signed-off-by: Zoey Zhang <zozhang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.