Skip to content

Use thread pool for status, run methods inside experiment + other fixes#295

Merged
hemildesai merged 7 commits intomainfrom
hemil/parallelize-status
Jul 18, 2025
Merged

Use thread pool for status, run methods inside experiment + other fixes#295
hemildesai merged 7 commits intomainfrom
hemil/parallelize-status

Conversation

@hemildesai
Copy link
Copy Markdown
Contributor

@hemildesai hemildesai commented Jul 16, 2025

Observed ~4x speedups in NeMo-Skills based workflows.

@hemildesai hemildesai requested a review from Kipok July 16, 2025 16:55
@hemildesai hemildesai changed the title Add thread pool to get status of jobs inside experiment Add thread pool to status, run methods inside experiment + other fixes Jul 16, 2025
@hemildesai hemildesai changed the title Add thread pool to status, run methods inside experiment + other fixes Use thread pool for status, run methods inside experiment + other fixes Jul 16, 2025
Kipok
Kipok previously approved these changes Jul 17, 2025
Copy link
Copy Markdown
Contributor

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, thanks for this amazing speed up!

Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai hemildesai merged commit a61734b into main Jul 18, 2025
20 checks passed
zoeyz101 pushed a commit to zoeyz101/NeMo-Run that referenced this pull request Nov 12, 2025
…es (NVIDIA-NeMo#295)

* Add thread pool to get status of jobs inside experiment

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* Add thread pools to experiment run

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* fixes

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* fix

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* fix

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* fix

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* fix

Signed-off-by: Hemil Desai <hemild@nvidia.com>

---------

Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Zoey Zhang <zozhang@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants