Upgrade skypilot to v0.10.0, introduce network_tier#297
Merged
hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom Jul 23, 2025
Merged
Upgrade skypilot to v0.10.0, introduce network_tier#297hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom
hemildesai merged 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
Contributor
|
Can you add some basic unit tests for your change to make https://github.com/NVIDIA-NeMo/Run/pull/297/checks?check_run_id=46524789496 pass? You can ignore the Thanks a lot for your contribution. |
Signed-off-by: Roee Landesman <roeeland@cisco.com>
Signed-off-by: Roee Landesman <roeeland@cisco.com>
ri-roee
force-pushed
the
upgrade/skypilot-0.10.0
branch
from
42c54d7 to
fdd7306
Compare
hemildesai
approved these changes
Jul 23, 2025
zoeyz101
pushed a commit
to zoeyz101/NeMo-Run
that referenced
this pull request
Nov 12, 2025
* Upgrade skypilot to v0.10.0, introduce network_tier Signed-off-by: Roee Landesman <roeeland@cisco.com> * add unit tests Signed-off-by: Roee Landesman <roeeland@cisco.com> --------- Signed-off-by: Roee Landesman <roeeland@cisco.com> Signed-off-by: Zoey Zhang <zozhang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #294