Added Pre-Launch Commands Support to LeptonExecutor#312
Merged
hemildesai merged 4 commits intoNVIDIA-NeMo:mainfrom Aug 6, 2025
Merged
Added Pre-Launch Commands Support to LeptonExecutor#312hemildesai merged 4 commits intoNVIDIA-NeMo:mainfrom
hemildesai merged 4 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: ansjindal <ansjindal@nvidia.com>
Contributor
|
Can you add tests for this change to make the CI pass? |
Contributor
Author
|
Yes, I will do it. |
Signed-off-by: ansjindal <ansjindal@nvidia.com>
Signed-off-by: ansjindal <ansjindal@nvidia.com>
Signed-off-by: ansjindal <ansjindal@nvidia.com>
Contributor
|
LGTM, can merge after @roclark approves. |
roclark
approved these changes
Aug 6, 2025
Contributor
roclark
left a comment
roclark
left a comment
There was a problem hiding this comment.
LGTM, thanks Anshul! Tested it out and works well for me.
zoeyz101
pushed a commit
to zoeyz101/NeMo-Run
that referenced
this pull request
Nov 12, 2025
* update lepton executor to include custom prelaunch commands section Signed-off-by: ansjindal <ansjindal@nvidia.com> * add test for prelaunch section Signed-off-by: ansjindal <ansjindal@nvidia.com> * add more tests for checking the pre-launch-commands section Signed-off-by: ansjindal <ansjindal@nvidia.com> * update lepton executor tests Signed-off-by: ansjindal <ansjindal@nvidia.com> --------- Signed-off-by: ansjindal <ansjindal@nvidia.com> Signed-off-by: Zoey Zhang <zozhang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom pre-launch commands in the
LeptonExecutor, allowing users to specify commands that run before the main job execution.pre_launch_commands: list[str]field toLeptonExecutordataclassExample Usage
The pre-launch commands are executed in sequence before the standard Lepton initialization, providing flexibility for custom job preparation while maintaining the existing workflow.